refactor: Update Client.run to have a better async I/O usage
#2645
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lulalaby
requested review from
NeloBlivion,
plun1331 and
Dorukyum
and removed request for
ChickenDevs
Dorukyum
requested changes
Nov 18, 2024
Co-authored-by: Dorukyum <[email protected]> Signed-off-by: DA344 <[email protected]>
Co-authored-by: Dorukyum <[email protected]> Signed-off-by: DA344 <[email protected]>
|
Applied all the changes Dorukyum requested. Before merging, I would like some feedback on this discussion message |
This has been fixed on the latest commit. |
|
I'll review and test that around 1pm |
Paillat-dev
requested changes
Sep 3, 2025
There was a problem hiding this comment.
Still having issues. Seems like changing to _loop in DiscordWebSocket fixes it but I'll let you confirm.
INFO:discord.client:logging in using static token
Traceback (most recent call last):
File "C:\Users\jerem\Documents\pycord\pycord\test_client_async.py", line 39, in <module>
asyncio.run(main())
File "C:\Users\jerem\AppData\Roaming\uv\python\cpython-3.12.11-windows-x86_64-none\Lib\asyncio\runners.py", line 195, in run
return runner.run(main)
^^^^^^^^^^^^^^^^
File "C:\Users\jerem\AppData\Roaming\uv\python\cpython-3.12.11-windows-x86_64-none\Lib\asyncio\runners.py", line 118, in run
return self._loop.run_until_complete(task)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "C:\Users\jerem\AppData\Roaming\uv\python\cpython-3.12.11-windows-x86_64-none\Lib\asyncio\base_events.py", line 691, in run_until_complete
return future.result()
^^^^^^^^^^^^^^^
File "C:\Users\jerem\Documents\pycord\pycord\test_client_async.py", line 33, in main
await bot.start(os.getenv("TOKEN_2", ""))
File "C:\Users\jerem\Documents\pycord\pycord\discord\client.py", line 872, in start
await self.connect(reconnect=reconnect)
File "C:\Users\jerem\Documents\pycord\pycord\discord\client.py", line 759, in connect
self.ws = await asyncio.wait_for(coro, timeout=60.0)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "C:\Users\jerem\AppData\Roaming\uv\python\cpython-3.12.11-windows-x86_64-none\Lib\asyncio\tasks.py", line 520, in wait_for
return await fut
^^^^^^^^^
File "C:\Users\jerem\Documents\pycord\pycord\discord\gateway.py", line 348, in from_client
ws = cls(socket, loop=client.loop)
^^^^^^^^^^^
File "C:\Users\jerem\Documents\pycord\pycord\discord\client.py", line 367, in loop
raise RuntimeError("loop is not set")
RuntimeError: loop is not set
ERROR:asyncio:Unclosed client session
client_session: <aiohttp.client.ClientSession object at 0x0000019183896540>
ERROR:asyncio:Unclosed connector
connections: ['deque([(<aiohttp.client_proto.ResponseHandler object at 0x00000191843B9A30>, 47503.546)])']
connector: <aiohttp.connector.TCPConnector object at 0x0000019183A48F80>
Test Code
import os
from discord import *
import asyncio
import logging
from dotenv import load_dotenv
logging.basicConfig(level=logging.INFO)
load_dotenv()
bot = Bot(intents=Intents.all())
class MyCog(Cog):
"""Example cog for the bot"""
def __init__(self, bot: Bot):
self.bot: Bot = bot
@Cog.listener()
async def on_ready(self):
print(f"Logged in as {self.bot.user} (ID: {self.bot.user.id})")
async def load_cogs():
bot.add_cog(MyCog(bot))
async def main():
await load_cogs()
try:
await bot.start(os.getenv("TOKEN_2", ""))
except KeyboardInterrupt:
await bot.close()
if __name__ == "__main__":
asyncio.run(main())Edit, no, that's not all, if you leave it running for some time after, leads to
Exception in thread Thread-1:
Traceback (most recent call last):
File "C:\Users\jerem\AppData\Roaming\uv\python\cpython-3.12.11-windows-x86_64-none\Lib\threading.py", line 1075, in _bootstrap_inner
self.run()
File "C:\Users\jerem\Documents\pycord\pycord\discord\gateway.py", line 167, in run
f = asyncio.run_coroutine_threadsafe(coro, loop=self.ws.loop)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "C:\Users\jerem\AppData\Roaming\uv\python\cpython-3.12.11-windows-x86_64-none\Lib\asyncio\tasks.py", line 950, in run_coroutine_threadsafe
loop.call_soon_threadsafe(callback)
^^^^^^^^^^^^^^^^^^^^^^^^^
AttributeError: 'NoneType' object has no attribute 'call_soon_threadsafe'
C:\Users\jerem\AppData\Roaming\uv\python\cpython-3.12.11-windows-x86_64-none\Lib\threading.py:1077: RuntimeWarning: coroutine 'DiscordWebSocket.send_heartbeat' was never awaited
self._invoke_excepthook(self)
RuntimeWarning: Enable tracemalloc to get the object allocation traceback
WARNING:discord.gateway:Can't keep up, shard ID None websocket is 49.8s behind.
WARNING:discord.gateway:Can't keep up, shard ID None websocket is 99.4s behind.
WARNING:discord.gateway:Can't keep up, shard ID None websocket is 149.0s behind.
Lumabots
reviewed
Sep 3, 2025
Paillat-dev
previously approved these changes
Sep 8, 2025
There was a problem hiding this comment.
Alright looks good, can't find any problem. Merge coflicts, and @Lumabots please test your loop stuff one last time with the latest changes.
|
tested and no issue with #2771 |
|
@Lulalaby when your merge this (once review is good) pls make sure to squash so that we can put it in rc2 and then revert it easily if problems |
pullapprove4
bot
added
PA: All Contributors pending
PA: Maintainers pending
and removed
PA: All Contributors pending
labels
Signed-off-by: Paillat <[email protected]>
Paillat-dev
approved these changes
Oct 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR refactors the
Client.runlogic to fix problems involving asyncio due to how the library used the loop:Needs testing
Exception
Information
examples, ...).
Checklist
type: ignorecomments were used, a comment is also left explaining why.